Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct test for serialization of a FontFaceRule #9401

Merged
merged 1 commit into from Feb 6, 2018

Conversation

Projects
None yet
4 participants
@csnardi
Copy link
Member

csnardi commented Feb 6, 2018

According to https://drafts.csswg.org/cssom/#serialize-a-url, URLs should be serialized as a string (https://drafts.csswg.org/cssom/#serialize-a-string), which includes double quotes on each side. Correct the test to match the spec. Also update the link for the spec; the old link no longer exists.

Correct test for serialization of a FontFaceRule
According to https://drafts.csswg.org/cssom/#serialize-a-url, URLs should be serialized as a string (https://drafts.csswg.org/cssom/#serialize-a-string), which includes double quotes on each side. Correct the test to match the spec. Also update the link for the spec; the old link no longer exists.
@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 6, 2018

Build PASSED

Started: 2018-02-06 01:42:47
Finished: 2018-02-06 01:57:49

Failing Jobs

  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@dbaron

dbaron approved these changes Feb 6, 2018

@dbaron dbaron merged commit 4fd593f into web-platform-tests:master Feb 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@csnardi csnardi deleted the csnardi:font-face-serialization branch Feb 6, 2018

fantasai added a commit to fantasai/web-platform-tests that referenced this pull request Feb 7, 2018

Correct test for serialization of a FontFaceRule (web-platform-tests#…
…9401)

According to https://drafts.csswg.org/cssom/#serialize-a-url, URLs should be serialized as a string (https://drafts.csswg.org/cssom/#serialize-a-string), which includes double quotes on each side. Correct the test to match the spec. Also update the link for the spec; the old link no longer exists.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.