Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom-elements: Fix a bug that HTML parser didn't set custom element state correctly for unknown "is" attribute value. #9405

Merged
merged 1 commit into from Feb 6, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 6, 2018

In HTML parser, if custom element definition is not found and the
element local name is invalid for custom element name, custom element
state of the element was set to "Uncustomized", which won't be upgraded.

It should be "Undefined" if "is" attribute exists.

Also, CustomElementRegistry::AddCandidate() didn't pick up a correct
name for customized built-in candidates.

A Blink layout test for :defined is upstreamed to WPT.

Bug: 736967
Change-Id: I583073eabc4ac276c6990161516c7b289905909b
Reviewed-on: https://chromium-review.googlesource.com/903423
Reviewed-by: Yoshifumi Inoue yosin@chromium.org
Commit-Queue: Kent Tamura tkent@chromium.org
Cr-Commit-Position: refs/heads/master@{#534621}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 6, 2018

Build PASSED

Started: 2018-02-06 04:32:54
Finished: 2018-02-06 04:37:05

View more information about this build on:

custom-elements: Fix a bug that HTML parser didn't set custom element…
… state correctly for unknown "is" attribute value.

In HTML parser, if custom element definition is not found and the
element local name is invalid for custom element name, custom element
state of the element was set to "Uncustomized", which won't be upgraded.

It should be "Undefined" if "is" attribute exists.

Also, CustomElementRegistry::AddCandidate() didn't pick up a correct
name for customized built-in candidates.

A Blink layout test for :defined is upstreamed to WPT.

Bug: 736967
Change-Id: I583073eabc4ac276c6990161516c7b289905909b
Reviewed-on: https://chromium-review.googlesource.com/903423
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534621}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-903423 branch from 61bcc01 to 4fc2724 Feb 6, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 82b5f59 into master Feb 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-903423 branch Feb 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.