Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate contentEditable to light tree children. #9409

Merged
merged 1 commit into from Feb 7, 2018

Conversation

Projects
None yet
3 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 6, 2018

contentEditable is implemented through -webkit-user-modify. We
propagated this property from shadow hosts to distributed children,
overriding inheritance through the flat tree for Shadow DOM v0. This CL
does the same for Shadow DOM v1.

https://html.spec.whatwg.org/multipage/interaction.html#attr-contenteditable

Bug: 809404
Change-Id: I54f3421317fe806fa71a8e4837ef1cc125978c66
Reviewed-on: https://chromium-review.googlesource.com/903925
Reviewed-by: Yoshifumi Inoue yosin@chromium.org
Reviewed-by: Hayato Ito hayato@chromium.org
Commit-Queue: Rune Lillesveen futhark@chromium.org
Cr-Commit-Position: refs/heads/master@{#534982}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 6, 2018

Build PASSED

Started: 2018-02-07 12:12:08
Finished: 2018-02-07 12:17:02

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-903925 branch from e7df569 to 897b482 Feb 7, 2018

Propagate contentEditable to light tree children.
contentEditable is implemented through -webkit-user-modify. We
propagated this property from shadow hosts to distributed children,
overriding inheritance through the flat tree for Shadow DOM v0. This CL
does the same for Shadow DOM v1.

https://html.spec.whatwg.org/multipage/interaction.html#attr-contenteditable

Bug: 809404
Change-Id: I54f3421317fe806fa71a8e4837ef1cc125978c66
Reviewed-on: https://chromium-review.googlesource.com/903925
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534982}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-903925 branch from 897b482 to 3d25296 Feb 7, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 96ad348 into master Feb 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-903925 branch Feb 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.