Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font-specific feature names are case-sensitive, not case insensitive. #9411

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@faceless2
Copy link
Contributor

faceless2 commented Feb 6, 2018

idents in @styleset rules - in fact these are case sensitive, so test
was reversed. Also removed -moz prefix for font-feature-settings
in test6 and test7 (@nattokirai this was originally yours)

Mike
Original testcase was testing for case-insensitivity of font-specific
idents in @styleset rules - in fact these are case sensitive, so test
was reversed. Also removed -moz prefix for font-feature-settings
in test6 and test7

@wpt-pr-bot wpt-pr-bot added the css-fonts label Feb 6, 2018

@faceless2 faceless2 changed the title Original testcase was testing for case-insensitivity of font-specific font-specific feature names are case-sensitive, not case insensitive. Feb 6, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 6, 2018

Build PASSED

Started: 2018-02-06 16:00:50
Finished: 2018-02-06 16:08:44

View more information about this build on:

@frivoal frivoal added the wg-css label Apr 30, 2018

@svgeesus

This comment has been minimized.

Copy link
Contributor

svgeesus commented May 1, 2018

@tabatkins would appreciate help on the syntax aspect. This is a fonts 4 test, and tests two things:

6.8. Alternates and swashes: the font-variant-alternates property
(ported over from fonts 3 to fonts 4)

6.9. Defining font specific alternates: the @font-feature-values rule
(this has a placeholder, saying it is being ported. the spec text is still here in level 3 )

given the change from CSS 2.1 syntax definitions (in Fonts 3) to CSS Syntax definitions (in Fonts 4) I just wanted your take on the case-sensitivity or case-insensitivity of idents in @styleset rules.

That will help me review the test and will also help me in porting over the spec text. Thanks!

@wpt-pr-bot wpt-pr-bot requested a review from drott May 1, 2018

@svgeesus svgeesus requested a review from tabatkins May 1, 2018

@svgeesus
Copy link
Contributor

svgeesus left a comment

Removal of -moz- is certainly correct.

The changes to the test are clear (changes case-insensitivity to case-sensitivity); what is less clear to me is what the correct syntax will be in the spec.

This is also affecting my porting of the spec text from the old .src preprocessor form and CSS 2.1 syntax definitions, to .bs bikeshed spec format and CSS Syntax 3 definitions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.