Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] Test that styleMap.set rejects invalid values. #9417

Merged
merged 1 commit into from Feb 12, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 6, 2018

Currently, our per-property tests only test that styleMap.set accept
valid values. This patch refactors the per-property tests a bit to
also test that we reject invalid values.

Bug: 774887
Change-Id: I41b5c4c1a6dfe6e766ff37fdc1b1f890dfb81aac
Reviewed-on: https://chromium-review.googlesource.com/905523
Commit-Queue: Darren Shen shend@chromium.org
Reviewed-by: nainar nainar@chromium.org
Cr-Commit-Position: refs/heads/master@{#536021}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 7, 2018

Build PASSED

Started: 2018-02-12 02:10:54
Finished: 2018-02-12 02:15:26

Failing Jobs

  • chrome:dev
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title [css-typed-om] Also test that styleMap.set rejects invalid values. [css-typed-om] Test that styleMap.set rejects invalid values. Feb 12, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-905523 branch from b91185b to 74afac4 Feb 12, 2018

[css-typed-om] Test that styleMap.set rejects invalid values.
Currently, our per-property tests only test that styleMap.set accept
valid values. This patch refactors the per-property tests a bit to
also test that we reject invalid values.

Bug: 774887
Change-Id: I41b5c4c1a6dfe6e766ff37fdc1b1f890dfb81aac
Reviewed-on: https://chromium-review.googlesource.com/905523
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536021}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-905523 branch from 74afac4 to 0b8ccf9 Feb 12, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 9d90463 into master Feb 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-905523 branch Feb 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.