Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-sizing] Intrinsic percentage non-replaced widths #9418

Conversation

@fantasai
Copy link
Contributor

fantasai commented Feb 7, 2018

Pending resolutions / edits for w3c/csswg-drafts#1132
Wasn't sure how to make it self-describing (other than copying the reference into the test, for a fairly long and complicated reference) without compromising understandability.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 7, 2018

Build PASSED

Started: 2018-02-07 03:13:02
Finished: 2018-02-07 03:18:35

View more information about this build on:

@fantasai fantasai force-pushed the fantasai:intrinsic-percentage-non-replaced-widths branch from 9eed31f to de85d6d Feb 7, 2018

@wpt-pr-bot

This comment has been minimized.

Copy link
Collaborator

wpt-pr-bot commented Feb 7, 2018

There are no owners for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@fantasai fantasai force-pushed the fantasai:intrinsic-percentage-non-replaced-widths branch from de85d6d to bc0d802 Feb 7, 2018

[css-sizing-3] Add tests for intrinsic size contribution (width/inlin…
…e-size) of non-replaced blocks with percentage widths. See w3c/csswg-drafts#1132

@fantasai fantasai force-pushed the fantasai:intrinsic-percentage-non-replaced-widths branch from bc0d802 to 2a85b63 Feb 7, 2018

@FremyCompany
Copy link
Contributor

FremyCompany left a comment

It seems those tests pass in all browsers, so I don't think there is anything controversial about them.

One question though: why do the test have calc(80px + 0%) entries but no calc(40px + 50%) entries? I would think that latter case is actually more complex that one where percentages are zero and can be safely ignored.

@FremyCompany

This comment has been minimized.

Copy link
Contributor

FremyCompany commented Mar 5, 2018

https://wptest.center/#/ejals5 has a test for latter case

@FremyCompany

This comment has been minimized.

Copy link
Contributor

FremyCompany commented Mar 5, 2018

https://wptest.center/#/l13fr2 for a test case with padding

@FremyCompany

This comment has been minimized.

Copy link
Contributor

FremyCompany commented Mar 5, 2018

And, just for good measure, a test that no browser passes:
https://wptest.center/#/f5atx4 for margin

@fantasai fantasai merged commit 5957997 into web-platform-tests:master Mar 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.