Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update list of properties whitelisted for first-letter #9419

Merged
merged 1 commit into from Feb 7, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 7, 2018

CSS Pseudo 4 1 expands the list of properties that can apply to
::first-letter when compared to CSS Selectors 3. Our list was based
primarily off of CSS Selectors 3; update per Pseudo 4. Also whitelist
variables within ::first-letter.

Bug: 660026, 715661
Change-Id: I950c7881506f8c36c3b917aff0ed2f1709d194ce
Reviewed-on: https://chromium-review.googlesource.com/899859
Reviewed-by: Alan Cutter alancutter@chromium.org
Commit-Queue: Chris Nardi cnardi@chromium.org
Cr-Commit-Position: refs/heads/master@{#535045}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 7, 2018

Build PENDING

Started: None
Finished: None

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-899859 branch 3 times, most recently from 26f5a3c to d887820 Feb 7, 2018

Update list of properties whitelisted for first-letter
CSS Pseudo 4 [1] expands the list of properties that can apply to
::first-letter when compared to CSS Selectors 3. Our list was based
primarily off of CSS Selectors 3; update per Pseudo 4. Also whitelist
variables within ::first-letter.

[1]: https://drafts.csswg.org/css-pseudo-4/#first-letter-styling

Bug: 660026, 715661
Change-Id: I950c7881506f8c36c3b917aff0ed2f1709d194ce
Reviewed-on: https://chromium-review.googlesource.com/899859
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535045}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-899859 branch from d887820 to a785087 Feb 7, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 5ed12a3 into master Feb 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-899859 branch Feb 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.