Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Rewrite RTC ICE and DTLS transport tests with alternative dependencies #9424
This PR rewrites the tests for RTCDtlsTransport and RTCIceTransport to have separate tests for getting the transports from both RTP sender/receiver and SCTP transport. The common parts of the assertions are factored out into separate functions so that they can be tested in multiple test cases.
I have tried to write the tests as dependency-neutral as possible, and test this specifically on Microsoft Edge 42.17083. However there are still some issues that cause the tests to still fail on Edge:
So despite my best effort I am unable to tweak the tests to pass on any of the current browsers. :( (perhaps the methodology also doesn't feel right)
If there are internal builds of browsers that have implemented the new features, please do run the tests and feedback on the test result is appreciated.
fippo left a comment
including adapter.js will get you an Edge RTCPeerConnection which supports addTrack and ice transports as well as dtls transports. It comes with its own quirks though (e.g. icetransport.statechange is still named icestatechange). More inline...
alvestrand left a comment
A number of things that I don't think are very readable. In particular, mixing state-changing (connecting PCs) and info-fetching (extracting the DTLS and ICE transports) makes the tests hard to read and maintain.