Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-layout-api] Adds LayoutCustom object, and changes box-tree. #9428

Merged
merged 1 commit into from Feb 9, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 7, 2018

This adds a stub class for "LayoutCustom". This contains no additional
logic yet to perform custom layout.

This does change how the box-tree is constructed.

  • display: layout(foo) is considered a new FC in all circumstances.
  • Depending of if "foo" has been registered, the children may/may-not
    become new FCs also.

Additionally this has the appropriate logic when a new layout class is
registered to trigger a reattachment of the layout tree.

Bug: 726125
Change-Id: I0e555c9f10afdfa314ce41f96b0636651e91cb7f
Reviewed-on: https://chromium-review.googlesource.com/889685
Commit-Queue: Ian Kilpatrick ikilpatrick@chromium.org
Reviewed-by: Morten Stenshorne mstensho@chromium.org
Reviewed-by: Rune Lillesveen futhark@chromium.org
Reviewed-by: Darren Shen shend@chromium.org
Reviewed-by: nainar nainar@chromium.org
Cr-Commit-Position: refs/heads/master@{#535858}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 7, 2018

Build PASSED

Started: 2018-02-09 22:57:45
Finished: 2018-02-09 23:02:50

Failing Jobs

  • chrome:dev
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-889685 branch 6 times, most recently from 270f3ac to d067ac3 Feb 8, 2018

[css-layout-api] Adds LayoutCustom object, and changes box-tree.
This adds a stub class for "LayoutCustom". This contains no additional
logic yet to perform custom layout.

This *does* change how the box-tree is constructed.
 - display: layout(foo) is considered a new FC in all circumstances.
 - Depending of if "foo" has been registered, the children may/may-not
   become new FCs also.

Additionally this has the appropriate logic when a new layout class is
registered to trigger a reattachment of the layout tree.

Bug: 726125
Change-Id: I0e555c9f10afdfa314ce41f96b0636651e91cb7f
Reviewed-on: https://chromium-review.googlesource.com/889685
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535858}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-889685 branch from d067ac3 to c6d5003 Feb 9, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 906eff4 into master Feb 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-889685 branch Feb 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.