Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constraint fixes #9431

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@kontomondo
Copy link

kontomondo commented Feb 7, 2018

This fixes two things:

  1. a typo in a loop where instead of using the length of fm2, fm1 is used, even though it's iterating through fm2's elements
  2. readonly attribute does not apply to input type file, colour and submit, as per https://html.spec.whatwg.org/multipage/input.html#concept-input-apply
@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 8, 2018

Build PASSED

Started: 2018-02-08 00:41:44
Finished: 2018-02-08 00:56:22

Failing Jobs

  • safari:11.0

View more information about this build on:

@domenic

This comment has been minimized.

Copy link
Member

domenic commented Feb 8, 2018

I don't think the second change is correct. While readonly may not "apply", the concept of "apply" doesn't impact the sentence in the spec that states

If the readonly attribute is specified on an input element, the element is barred from constraint validation.

That is, "specified" is unrelated to "apply".

It's notable that browsers pass all the tests you are removing, so probably we should not remove them.

@kontomondo

This comment has been minimized.

Copy link
Author

kontomondo commented Feb 8, 2018

@domenic There's also a clarifying note in there:

Only text controls can be made read-only, since for other controls (such as checkboxes and buttons) there is no useful distinction between being read-only and being disabled, so the readonly attribute does not apply.

So this to me is rather ambiguous. The test also specifically doesn't cover "checkbox", "button" and "radio" types, how/why are they different ?

The way I was interpreting "specified" is essentially "the attribute applies and is present" on the element. My interpretation could very well be wrong of course.

@domenic

This comment has been minimized.

Copy link
Member

domenic commented Feb 8, 2018

"specified" generally has a very specific meaning; it means "the element has the attribute". I agree it could probably be clearer.

I'm not sure exactly why the tests don't cover those other types. Maybe they should?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.