Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom-elements: document.createElementNS should not create HTMLUnknownElement for a valid custom element name #9433

Merged
merged 1 commit into from Feb 8, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 8, 2018

Document::CreatRawElement() should check CustomElement::IsValidName().
It failed only if the Document didn't have V0 RegistrationContext.

Bug: 809887
Change-Id: I4e5d283658673db3e1db15b136ca5729d29e2442
Reviewed-on: https://chromium-review.googlesource.com/908128
Reviewed-by: Yoshifumi Inoue yosin@chromium.org
Commit-Queue: Kent Tamura tkent@chromium.org
Cr-Commit-Position: refs/heads/master@{#535299}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 8, 2018

Build PASSED

Started: 2018-02-08 04:46:54
Finished: 2018-02-08 04:51:27

View more information about this build on:

custom-elements: document.createElementNS should not create HTMLUnkno…
…wnElement for a valid custom element name

Document::CreatRawElement() should check CustomElement::IsValidName().
It failed only if the Document didn't have V0 RegistrationContext.

Bug: 809887
Change-Id: I4e5d283658673db3e1db15b136ca5729d29e2442
Reviewed-on: https://chromium-review.googlesource.com/908128
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535299}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-908128 branch from aa7b159 to d9927fc Feb 8, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit e05c355 into master Feb 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-908128 branch Feb 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.