Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service worker: Disallow opaque responses for WebVTT. #9436

Merged
merged 1 commit into from Feb 9, 2018

Conversation

Projects
None yet
3 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 8, 2018

WebVTT loading code was determining if a response was cross-origin by looking
at request URL. But a service worker may have intercepted the request and
provided a response from cross-origin.

Bug: 808825
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ia121c0a8eae782de93d9777603426500a9709f8c
Reviewed-on: https://chromium-review.googlesource.com/907013
Reviewed-by: Tsuyoshi Horo horo@chromium.org
Reviewed-by: Kinuko Yasuda kinuko@chromium.org
Commit-Queue: Matt Falkenhagen falken@chromium.org
Cr-Commit-Position: refs/heads/master@{#535625}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 8, 2018

Build PASSED

Started: 2018-02-09 04:18:38
Finished: 2018-02-09 04:24:19

View more information about this build on:

service worker: Disallow opaque responses for WebVTT.
WebVTT loading code was determining if a response was cross-origin by looking
at request URL. But a service worker may have intercepted the request and
provided a response from cross-origin.

Bug: 808825
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ia121c0a8eae782de93d9777603426500a9709f8c
Reviewed-on: https://chromium-review.googlesource.com/907013
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535625}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-907013 branch from 2374f1e to 355af21 Feb 9, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 0c874a2 into master Feb 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-907013 branch Feb 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.