Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom-elements: Element with a valid custom element name created by createElement(name, options) should be upgraded #9437

Merged
merged 1 commit into from Feb 9, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 8, 2018

createElement('my-foo', {}) was not upgraded even though
createElement('my-foo') is upgraded. Document::CreateElement() should
set "undefined" state even if the local name is valid for Custom Element
V0.

Bug: 810289
Change-Id: If70c40d6de520fe79b73e7fb6b21d776e636fee9
Reviewed-on: https://chromium-review.googlesource.com/907912
Reviewed-by: Yoshifumi Inoue yosin@chromium.org
Commit-Queue: Kent Tamura tkent@chromium.org
Cr-Commit-Position: refs/heads/master@{#535627}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 8, 2018

Build PASSED

Started: 2018-02-09 04:24:53
Finished: 2018-02-09 04:32:45

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-907912 branch from 89b611c to 4d69e97 Feb 8, 2018

custom-elements: Element with a valid custom element name created by …
…createElement(name, options) should be upgraded

createElement('my-foo', {}) was not upgraded even though
createElement('my-foo') is upgraded. Document::CreateElement() should
set "undefined" state even if the local name is valid for Custom Element
V0.

Bug: 810289
Change-Id: If70c40d6de520fe79b73e7fb6b21d776e636fee9
Reviewed-on: https://chromium-review.googlesource.com/907912
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535627}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-907912 branch from 4d69e97 to 8b9e8f4 Feb 9, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit b0ff0ea into master Feb 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-907912 branch Feb 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.