Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Picture-in-Picture] Add test for consuming user gesture. #9439

Merged
merged 1 commit into from Feb 9, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 8, 2018

This merge all request Picture-in-Picture tests into one test file and
adds one test to make sure user gesture is consumed by request
Picture-in-Picture so that a site couldn't produce a popup and a video
played in Picture-in-Picture on the same gesture.

Bug: 806249
Change-Id: Id974342b5cb48c1b60a44074d41603e93d2192e7
Reviewed-on: https://chromium-review.googlesource.com/909148
Reviewed-by: Mounir Lamouri mlamouri@chromium.org
Reviewed-by: apacible apacible@chromium.org
Commit-Queue: Mounir Lamouri mlamouri@chromium.org
Cr-Commit-Position: refs/heads/master@{#535694}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 8, 2018

Build PASSED

Started: 2018-02-09 13:04:15
Finished: 2018-02-09 13:08:59

Failing Jobs

  • safari:11.0

Unstable Results

Browser: "Safari 11.0" (failures allowed)

View in: WPT PR Status | TravisCI

Test Subtest Results Messages
/picture-in-picture/request-picture-in-picture.html   TIMEOUT: 3
OK: 7
  request Picture-in-Picture consumes user gesture FAIL: 7
promise_test: Unhandled rejection with value: object "Error: document.elementsFromPoint unsupported"
  request Picture-in-Picture requires a user gesture FAIL: 7
document.createElement('video').requestPictureInPicture is not a function. (In 'document.createElement('video').requestPictureInPicture()', 'document.createElement('video').requestPictureInPicture' is undefined)
  request Picture-in-Picture resolves on user click FAIL: 7
promise_test: Unhandled rejection with value: object "Error: document.elementsFromPoint unsupported"

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title [Picture-in-Picture] Add more tests for user gesture [Picture-in-Picture] Add test for consuming user gesture. Feb 9, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-909148 branch from dd6f4be to 293a2e4 Feb 9, 2018

[Picture-in-Picture] Add test for consuming user gesture.
This merge all request Picture-in-Picture tests into one test file and
adds one test to make sure user gesture is consumed by request
Picture-in-Picture so that a site couldn't produce a popup and a video
played in Picture-in-Picture on the same gesture.

Bug: 806249
Change-Id: Id974342b5cb48c1b60a44074d41603e93d2192e7
Reviewed-on: https://chromium-review.googlesource.com/909148
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: apacible <apacible@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535694}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-909148 branch from 293a2e4 to 6fd9809 Feb 9, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 700a6ba into master Feb 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-909148 branch Feb 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.