Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LayoutNG] Improve min/max calculation wrt. floats. #9442

Merged
merged 1 commit into from Feb 12, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 8, 2018

The presence of floats complicate min/max intrinsic inline size
calculation. They affect lines and child blocks in the same block
formatting context. Therefore, when calculating min/max sizes of a
child, we need to pass along information about floats adjacent to the
current "virtual" block position.

This change actually makes NG slightly "better" than legacy Blink
layout, Edge and Firefox. This may be an issue for compatibility. It
should be fairly easy to "dumb down" the machinery to be compatible with
the others, though, if this should become an issue. Two tests regressed
because of this. Reported bug 810370. This change also caused
grid-item-margins-not-collapse-expected.html to make room for the floats to
fit beside each other, so I modified it. Also removed bogus "margin"
attributes.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I59730d7333fa7699a42ab93d2c4674c267d834aa
Reviewed-on: https://chromium-review.googlesource.com/908753
Commit-Queue: Morten Stenshorne mstensho@chromium.org
Reviewed-by: Ian Kilpatrick ikilpatrick@chromium.org
Reviewed-by: Christian Biesinger cbiesinger@chromium.org
Reviewed-by: Koji Ishii kojii@chromium.org
Cr-Commit-Position: refs/heads/master@{#536044}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 8, 2018

Build PASSED

Started: 2018-02-12 09:58:35
Finished: 2018-02-12 10:05:25

Failing Jobs

  • chrome:dev
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-908753 branch 3 times, most recently from b305f9a to cb8b492 Feb 9, 2018

[LayoutNG] Improve min/max calculation wrt. floats.
The presence of floats complicate min/max intrinsic inline size
calculation. They affect lines and child blocks in the same block
formatting context. Therefore, when calculating min/max sizes of a
child, we need to pass along information about floats adjacent to the
current "virtual" block position.

This change actually makes NG slightly "better" than legacy Blink
layout, Edge and Firefox. This may be an issue for compatibility. It
should be fairly easy to "dumb down" the machinery to be compatible with
the others, though, if this should become an issue. Two tests regressed
because of this. Reported bug 810370. This change also caused
grid-item-margins-not-collapse-expected.html to make room for the floats to
fit beside each other, so I modified it. Also removed bogus "margin"
attributes.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I59730d7333fa7699a42ab93d2c4674c267d834aa
Reviewed-on: https://chromium-review.googlesource.com/908753
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536044}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-908753 branch from cb8b492 to 9001167 Feb 12, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 84696c4 into master Feb 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-908753 branch Feb 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.