Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluetooth: FakeBluetoothChooser stub impl. #9463

Merged
merged 1 commit into from Mar 17, 2018

Conversation

Projects
None yet
5 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 9, 2018

This change adds a new FakeBluetoothChooser interface stub to expand on.
The design for this class is detailed in the following document:
https://docs.google.com/document/d/1XFl_4ZAgO8ddM6U53A9AfUuZeWgJnlYD5wtbXqEpzeg

BUG=719827

Change-Id: I34169ce62dd5b35796639b7643d899b8315cc4c7
Reviewed-on: https://chromium-review.googlesource.com/909726
Commit-Queue: Ovidio Henriquez odejesush@chromium.org
Reviewed-by: Daniel Cheng dcheng@chromium.org
Reviewed-by: Kinuko Yasuda kinuko@chromium.org
Reviewed-by: Conley Owens cco3@chromium.org
Reviewed-by: Giovanni Ortuño Urquidi ortuno@chromium.org
Cr-Commit-Position: refs/heads/master@{#543479}


This change is Reviewable

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-909726 branch from 0093b23 to 0467c62 Feb 9, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 9, 2018

Build ERRORED

Started: 2018-03-16 01:41:28
Finished: 2018-03-16 01:44:11

Failing Jobs

  • firefox:nightly
  • resources_unittest in py27

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-909726 branch 5 times, most recently from ff792f9 to 90d1ac0 Feb 9, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-909726 branch 3 times, most recently from 5937f7b to 6f27522 Feb 20, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-909726 branch 8 times, most recently from b354ffc to b523463 Mar 2, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-909726 branch 5 times, most recently from def88b0 to 39f217d Mar 9, 2018

bluetooth: FakeBluetoothChooser stub impl.
This change adds a new FakeBluetoothChooser interface stub to expand on.
The design for this class is detailed in the following document:
https://docs.google.com/document/d/1XFl_4ZAgO8ddM6U53A9AfUuZeWgJnlYD5wtbXqEpzeg

BUG=719827

Change-Id: I34169ce62dd5b35796639b7643d899b8315cc4c7
Reviewed-on: https://chromium-review.googlesource.com/909726
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Conley Owens <cco3@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543479}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-909726 branch from 39f217d to 87894eb Mar 15, 2018

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Mar 17, 2018

The Firefox job is timing out and failing because there are too many affected tests, see #7660

I'll bypass checks and merge anyway.

@foolip foolip merged commit ecd2c46 into master Mar 17, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@foolip foolip deleted the chromium-export-cl-909726 branch Mar 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.