Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for PaymentInstruments. #9467

Merged
merged 9 commits into from Feb 28, 2018

Conversation

Projects
None yet
4 participants
@rsolomakhin
Copy link
Contributor

rsolomakhin commented Feb 9, 2018

@marcoscaceres: Please take a look at this initial set of tests for the PaymentInstruments interface. Thank you!

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 9, 2018

Build PASSED

Started: 2018-02-27 16:20:40
Finished: 2018-02-27 16:26:50

View more information about this build on:

@rsolomakhin rsolomakhin force-pushed the rsolomakhin:payment-handler branch from d4d8d93 to a080956 Feb 13, 2018

@marcoscaceres
Copy link
Contributor

marcoscaceres left a comment

LGTM.

},
);
return promise_rejects(t, new TypeError(), setPromise);
}, 'Cannot register instruments with very long icon media type image/pngggggg...');

This comment has been minimized.

Copy link
@marcoscaceres

marcoscaceres Feb 27, 2018

Contributor

This restriction seems odd? is this in the MIME spec?

This comment has been minimized.

Copy link
@rsolomakhin

rsolomakhin Feb 27, 2018

Author Contributor

My bad. the description really should be "Don't crash when registering instrument with very long icon media type image/pngggg..."

<script src="register-and-activate-service-worker.js"></script>
<p>When the payment sheet is shown, please authorize the mock payment.</p>
<script>
// Use a different scope for the payment handler, because Chrome closes all

This comment has been minimized.

Copy link
@marcoscaceres

marcoscaceres Feb 27, 2018

Contributor

This comment seems Chrome specific?

This comment has been minimized.

Copy link
@rsolomakhin

rsolomakhin Feb 27, 2018

Author Contributor

Removed

@marcoscaceres

This comment has been minimized.

Copy link
Contributor

marcoscaceres commented Feb 27, 2018

Couple of questions, but overall the tests seem good.

@rsolomakhin

This comment has been minimized.

Copy link
Contributor Author

rsolomakhin commented Feb 27, 2018

@marcoscaceres: Thank you for the review! I've addressed your comments. Please take another look.

@rsolomakhin rsolomakhin merged commit ae54e16 into web-platform-tests:master Feb 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rsolomakhin rsolomakhin deleted the rsolomakhin:payment-handler branch Mar 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.