Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1435596] Give cross-origin objects (windows and locations) a 'then' property in all cases. #9470

Merged
merged 1 commit into from Feb 10, 2018

Conversation

Projects
None yet
4 participants
@moz-wptsync-bot
Copy link
Collaborator

moz-wptsync-bot commented Feb 10, 2018

For locations, it always returns undefined. For windows, it returns undefined
unless there is a named subframe named "then", in which case that named
subframe is returned.

The idea is to be able to resolve promises with cross-origin objects.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1435596
gecko-commit: 1f3a5b496acd2288cc8cf0c32af86cb35157ea4e
gecko-integration-branch: mozilla-inbound
gecko-reviewers: bholley

Give cross-origin objects (windows and locations) a 'then' property i…
…n all cases.

For locations, it always returns undefined.  For windows, it returns undefined
unless there is a named subframe named "then", in which case that named
subframe is returned.

The idea is to be able to resolve promises with cross-origin objects.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1435596
gecko-commit: 1f3a5b496acd2288cc8cf0c32af86cb35157ea4e
gecko-integration-branch: mozilla-inbound
gecko-reviewers: bholley
@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 10, 2018

Build PASSED

Started: 2018-02-10 06:33:17
Finished: 2018-02-10 06:54:28

Failing Jobs

  • chrome:dev
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@moz-wptsync-bot moz-wptsync-bot merged commit ac250e4 into master Feb 10, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
upstream/gecko Landed on mozilla-central
Details

@sideshowbarker sideshowbarker deleted the sync/upstream/open/1435596 branch Nov 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.