Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LinearAccelerationSensor shake threshold manual test #9473

Merged
merged 3 commits into from Feb 23, 2018

Conversation

Projects
None yet
4 participants
@kaixinjxq
Copy link
Contributor

kaixinjxq commented Feb 11, 2018

No description provided.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 11, 2018

Build PASSED

Started: 2018-02-23 09:37:38
Finished: 2018-02-23 09:51:07

View more information about this build on:

});
sensor.start();
}, "Test that shake gesture along x axis of the device, threshold can greater than 25");

This comment has been minimized.

Copy link
@Honry

Honry Feb 23, 2018

Contributor

's/shake/when shaking'
's/threshold/the shake threshold'
's/can/can be'

This comment has been minimized.

Copy link
@kaixinjxq

kaixinjxq Feb 23, 2018

Author Contributor

Fixed, @Honry, PTAL.

@@ -0,0 +1,32 @@
<!DOCTYPE html>

This comment has been minimized.

Copy link
@Honry

Honry Feb 23, 2018

Contributor

LinearAccelerationSensor-threshold-manual.https.html

The file name looks like inappropriate, how about LinearAccelerationSensor-shake-threshold-manual.https.html?

This comment has been minimized.

Copy link
@kaixinjxq

kaixinjxq Feb 23, 2018

Author Contributor

Updated, @Honry, PTAL.

@Honry

Honry approved these changes Feb 23, 2018

Copy link
Contributor

Honry left a comment

thanks, LGTM

@Honry Honry merged commit b2644a4 into web-platform-tests:master Feb 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kaixinjxq kaixinjxq deleted the kaixinjxq:Sensor_shake_threshold branch Feb 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.