Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore order when parsing inset and color for box-shadow #9474

Merged
merged 1 commit into from Feb 13, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 11, 2018

According to the spec 1, box-shadow should allow the inset keyword and
a color in any order. Our implementation allowed only 2 out of the 4
possible orders; fix our parsing to match the spec.

Bug: 811083
Change-Id: I54c3d15c177702624994c45044b446fd82fc9d98
Reviewed-on: https://chromium-review.googlesource.com/911994
Commit-Queue: Chris Nardi cnardi@chromium.org
Reviewed-by: Emil A Eklund eae@chromium.org
Cr-Commit-Position: refs/heads/master@{#536270}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 11, 2018

Build PASSED

Started: 2018-02-13 06:48:06
Finished: 2018-02-13 06:56:30

Failing Jobs

  • chrome:dev
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-911994 branch 4 times, most recently from bb97ad5 to 84b5b37 Feb 12, 2018

Ignore order when parsing inset and color for box-shadow
According to the spec [1], box-shadow should allow the inset keyword and
a color in any order. Our implementation allowed only 2 out of the 4
possible orders; fix our parsing to match the spec.

[1]: https://drafts.csswg.org/css-backgrounds/#typedef-shadow

Bug: 811083
Change-Id: I54c3d15c177702624994c45044b446fd82fc9d98
Reviewed-on: https://chromium-review.googlesource.com/911994
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536270}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-911994 branch from 84b5b37 to f27d188 Feb 13, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 9c1c6c3 into master Feb 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-911994 branch Feb 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.