Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] Implement CSSTransformComponent.toMatrix(). #9475

Merged
merged 1 commit into from Feb 12, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 11, 2018

This patch implements CSSTransformComponent.toMatrix(), which was
previously implemented as AsMatrix() but just not webexposed. We also
split up the tests since it makes more sense.

Bug: 807877
Change-Id: Icee742fdde033d63cea85a27250e91a71ad67e2a
Reviewed-on: https://chromium-review.googlesource.com/910529
Commit-Queue: Darren Shen shend@chromium.org
Reviewed-by: nainar nainar@chromium.org
Cr-Commit-Position: refs/heads/master@{#536022}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 11, 2018

Build PASSED

Started: 2018-02-12 02:15:59
Finished: 2018-02-12 02:24:43

Failing Jobs

  • chrome:dev
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-910529 branch from 4601551 to 25baf77 Feb 12, 2018

[css-typed-om] Implement CSSTransformComponent.toMatrix().
This patch implements CSSTransformComponent.toMatrix(), which was
previously implemented as AsMatrix() but just not webexposed. We also
split up the tests since it makes more sense.

Bug: 807877
Change-Id: Icee742fdde033d63cea85a27250e91a71ad67e2a
Reviewed-on: https://chromium-review.googlesource.com/910529
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536022}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-910529 branch from 25baf77 to 400a3f2 Feb 12, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 8d2483f into master Feb 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-910529 branch Feb 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.