Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import error for Servo executor. #9476

Merged
merged 2 commits into from Feb 12, 2018

Conversation

Projects
None yet
5 participants
@jdm
Copy link
Contributor

jdm commented Feb 12, 2018

This regressed in 040654c as part of #8614.


This change is Reviewable

jdm added some commits Feb 12, 2018

@wpt-pr-bot wpt-pr-bot added the infra label Feb 12, 2018

@wpt-pr-bot wpt-pr-bot requested review from gsnedders and jgraham Feb 12, 2018

@jdm

This comment has been minimized.

Copy link
Contributor Author

jdm commented Feb 12, 2018

ValueError: Attempted relative import beyond toplevel package

  File "/Users/jdm/src/master-servo/python/servo/testing_commands.py", line 436, in update_manifest
    return self.test_wpt(**kwargs)
  File "/Users/jdm/src/master-servo/python/servo/testing_commands.py", line 371, in test_wpt
    ret = self.run_test_list_or_dispatch(kwargs["test_list"], "wpt", self._test_wpt, **kwargs)
  File "/Users/jdm/src/master-servo/python/servo/testing_commands.py", line 395, in run_test_list_or_dispatch
    return correct_function(**kwargs)
  File "/Users/jdm/src/master-servo/python/servo/testing_commands.py", line 381, in _test_wpt
    return self.wptrunner(run_file, **kwargs)
  File "/Users/jdm/src/master-servo/python/servo/testing_commands.py", line 427, in wptrunner
    return run_globals["run_tests"](**kwargs)
  File "/Users/jdm/src/master-servo/tests/wpt/run_wpt.py", line 13, in run_tests
    return run.run_tests(paths=paths, **kwargs)
  File "/Users/jdm/src/master-servo/tests/wpt/run.py", line 46, in run_tests
    success = wptrunner.run_tests(**kwargs)
  File "/Users/jdm/src/master-servo/tests/wpt/web-platform-tests/tools/wptrunner/wptrunner/wptrunner.py", line 142, in run_tests
    env_options, get_env_extras, run_info_extras) = products.load_product(config, product)
  File "/Users/jdm/src/master-servo/tests/wpt/web-platform-tests/tools/wptrunner/wptrunner/products.py", line 34, in load_product
    module = product_module(config, product)
  File "/Users/jdm/src/master-servo/tests/wpt/web-platform-tests/tools/wptrunner/wptrunner/products.py", line 25, in product_module
    module = importlib.import_module("wptrunner.browsers." + product)
  File "/usr/local/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/importlib/__init__.py", line 37, in import_module
    __import__(name)
  File "/Users/jdm/src/master-servo/tests/wpt/web-platform-tests/tools/wptrunner/wptrunner/browsers/servo.py", line 5, in <module>
    from ..executors.executorservo import ServoTestharnessExecutor, ServoRefTestExecutor, ServoWdspecExecutor
  File "/Users/jdm/src/master-servo/tests/wpt/web-platform-tests/tools/wptrunner/wptrunner/executors/executorservo.py", line 16, in <module>
    from serve.serve import make_hosts_file
  File "/Users/jdm/src/master-servo/tests/wpt/web-platform-tests/tools/serve/__init__.py", line 1, in <module>
    import serve
  File "/Users/jdm/src/master-servo/tests/wpt/web-platform-tests/tools/serve/serve.py", line 20, in <module>
    from ..localpaths import repo_root
@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 12, 2018

Build PASSED

Started: 2018-02-12 02:59:24
Finished: 2018-02-12 03:10:48

View more information about this build on:

@jgraham jgraham merged commit cdfdcce into master Feb 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@@ -5,7 +5,7 @@

from mozprocess import ProcessHandler

from serve.serve import make_hosts_file
from tools.serve.serve import make_hosts_file

This comment has been minimized.

Copy link
@gsnedders

gsnedders Feb 13, 2018

Contributor

In principle wptrunner should work when installed, so we probably can't rely on tools being available. It should definitely have serve in the import path, though… :/

@gsnedders gsnedders deleted the jdm-patch-3 branch Feb 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.