Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1424878] Not having cached style data doesn't guarantee we don't need to update media query stuff. #9477

Merged
merged 1 commit into from Feb 13, 2018

Conversation

Projects
None yet
4 participants
@moz-wptsync-bot
Copy link
Collaborator

moz-wptsync-bot commented Feb 12, 2018

In particular, even when there are no frames, we may have used the rule
cascades / stylist data (for different stuff, like font-feature-values, thus the
regressing bug).

Using the old rule cascades / stylist data without knowing it has changed is
wrong, thus the bug.

Now that media query change stuff is async and has a well-defined processing
point, we should be able to just call it without too much worry.

Also note that at the point the extra hints are passed, if there's no root frame
/ elements are not styled / etc, we'll optimize away the change hint.

The test-case intermittently fails without this patch, but I didn't manage to
make a better one, unfortunately :(
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1424878
gecko-commit: 88b42bd5847abac58a62c4d6b33c1509bfce5f3d
gecko-integration-branch: autoland
gecko-reviewers: bz

Not having cached style data doesn't guarantee we don't need to updat…
…e media query stuff.

In particular,  even when there are no frames, we may have used the rule
cascades / stylist data (for different stuff, like font-feature-values, thus the
regressing bug).

Using the old rule cascades / stylist data without knowing it has changed is
wrong, thus the bug.

Now that media query change stuff is async and has a well-defined processing
point, we should be able to just call it without too much worry.

Also note that at the point the extra hints are passed, if there's no root frame
/ elements are not styled / etc, we'll optimize away the change hint.

The test-case intermittently fails without this patch, but I didn't manage to
make a better one, unfortunately :(
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1424878
gecko-commit: 88b42bd5847abac58a62c4d6b33c1509bfce5f3d
gecko-integration-branch: autoland
gecko-reviewers: bz
@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 12, 2018

Build PASSED

Started: 2018-02-12 09:50:15
Finished: 2018-02-12 09:57:55

Failing Jobs

  • chrome:dev
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@moz-wptsync-bot moz-wptsync-bot merged commit a076c3e into master Feb 13, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
upstream/gecko Landed on mozilla-central
Details

@sideshowbarker sideshowbarker deleted the gecko/sync/upstream/open/1424878/1 branch Nov 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.