Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve RTCRtpSender.replaceTrack tests' Firefox compatibility #9479

Merged
merged 1 commit into from Feb 12, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 12, 2018

The current test relies on addTrack(track) which is not the
API tested. Using addTrack(track, stream) works in Firefox
as well as Chrome.

BUG=790007

Change-Id: I098101cd6556620c42b4f51df98ef54b0a8ad1f7
Reviewed-on: https://chromium-review.googlesource.com/912289
Commit-Queue: Henrik Boström hbos@chromium.org
Reviewed-by: Henrik Boström hbos@chromium.org
Cr-Commit-Position: refs/heads/master@{#536063}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 12, 2018

Build PASSED

Started: 2018-02-12 12:32:53
Finished: 2018-02-12 12:36:43

Failing Jobs

  • chrome:dev
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title Improve RTCRtpSender.replaceTrack tests compability with Firefox Improve RTCRtpSender.replaceTrack tests' Firefox compatibility Feb 12, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-912289 branch from fbd7635 to 080ef2f Feb 12, 2018

Improve RTCRtpSender.replaceTrack tests' Firefox compatibility
The current test relies on addTrack(track) which is not the
API tested. Using addTrack(track, stream) works in Firefox
as well as Chrome.

BUG=790007

Change-Id: I098101cd6556620c42b4f51df98ef54b0a8ad1f7
Reviewed-on: https://chromium-review.googlesource.com/912289
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536063}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-912289 branch from 080ef2f to dd5318e Feb 12, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit e02ec4a into master Feb 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-912289 branch Feb 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.