Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async Cookies: Fix globals in idlharness test #9486

Merged
merged 1 commit into from Feb 12, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 12, 2018

Globals (Window, ServiceWorkerGlobalScope, etc) get special bindings
treatment for methods/properties and IDL tests for features need to
declare these types correctly for correct results. Fix the SW test for
the new cookie store API by marking the global with the [Global]
extended attribute; this reveals that our implementation passes all
the bindings test cases.

Bug: 729800
Change-Id: I87747ed2af8d932342e24c9400524d88c9df73a7
Reviewed-on: https://chromium-review.googlesource.com/914568
Commit-Queue: Victor Costan pwnall@chromium.org
Reviewed-by: Victor Costan pwnall@chromium.org
Cr-Commit-Position: refs/heads/master@{#536189}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 12, 2018

Build PASSED

Started: 2018-02-12 21:30:00
Finished: 2018-02-12 21:37:21

Failing Jobs

  • chrome:dev
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

Async Cookies: Fix globals in idlharness test
Globals (Window, ServiceWorkerGlobalScope, etc) get special bindings
treatment for methods/properties and IDL tests for features need to
declare these types correctly for correct results. Fix the SW test for
the new cookie store API by marking the global with the [Global]
extended attribute; this reveals that our implementation passes all
the bindings test cases.

Bug: 729800
Change-Id: I87747ed2af8d932342e24c9400524d88c9df73a7
Reviewed-on: https://chromium-review.googlesource.com/914568
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536189}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-914568 branch from a54fbbc to 120654f Feb 12, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit b0e401a into master Feb 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-914568 branch Feb 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.