Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1437255] Use a null prototype for @@unscopables objects in the DOM. #9490

Merged
merged 2 commits into from Feb 22, 2018

Conversation

Projects
None yet
5 participants
@moz-wptsync-bot
Copy link
Collaborator

moz-wptsync-bot commented Feb 13, 2018

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1437255
gecko-commit: a6088a5f48ee299386a84d2f771902267d7355b1
gecko-integration-branch: mozilla-inbound
gecko-reviewers: qdot


This change is Reviewable

Use a null prototype for @@unscopables objects in the DOM.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1437255
gecko-commit: a6088a5f48ee299386a84d2f771902267d7355b1
gecko-integration-branch: mozilla-inbound
gecko-reviewers: qdot
@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 13, 2018

Build ERRORED

Started: 2018-02-21 17:19:14
Finished: 2018-02-21 18:13:35

Failing Jobs

  • firefox:nightly
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@bzbarsky

This comment has been minimized.

Copy link
Contributor

bzbarsky commented Feb 22, 2018

@jgraham Looks like the unittest job passes now, right?

@jgraham jgraham merged commit 9192f4b into master Feb 22, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@TimothyGu TimothyGu deleted the sync/upstream/open/1437255 branch Apr 11, 2018

foolip added a commit that referenced this pull request Jul 27, 2018

Fold "Unscopable handled correctly" tests into the attribute/operatio…
…n tests

The `[Unscopable]` checks were added here:
#9490

However, this extended attribute is very rarely used, currently only
in DOM and Fullscreen. And yet, every property and operation generates
a test like this, which is normally passing, example:
https://wpt.fyi/results/compat/interfaces.any.html

Just fold these into the existing tests for attributes/operations like
the many other aspects already covered. Because of the
"do_interface_attribute_asserts must be the last thing" problem,
change of structure for the attribute test.

foolip added a commit that referenced this pull request Aug 1, 2018

Fold "Unscopable handled correctly" tests into the attribute/operatio…
…n tests (#12211)

The `[Unscopable]` checks were added here:
#9490

However, this extended attribute is very rarely used, currently only
in DOM and Fullscreen. And yet, every property and operation generates
a test like this, which is normally passing, example:
https://wpt.fyi/results/compat/interfaces.any.html

Just fold these into the existing tests for attributes/operations like
the many other aspects already covered. Because of the
"do_interface_attribute_asserts must be the last thing" problem,
there's a change of structure for the attribute test.

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Aug 4, 2018

Bug 1478998 [wpt PR 12211] - Fold "Unscopable handled correctly" test…
…s into the attribute/operation tests, a=testonly

Automatic update from web-platform-testsFold "Unscopable handled correctly" tests into the attribute/operation tests (#12211)

The `[Unscopable]` checks were added here:
web-platform-tests/wpt#9490

However, this extended attribute is very rarely used, currently only
in DOM and Fullscreen. And yet, every property and operation generates
a test like this, which is normally passing, example:
https://wpt.fyi/results/compat/interfaces.any.html

Just fold these into the existing tests for attributes/operations like
the many other aspects already covered. Because of the
"do_interface_attribute_asserts must be the last thing" problem,
there's a change of structure for the attribute test.
--

wpt-commits: 2f8b11a39d4da8d729903b1b30557a875d5bf76a
wpt-pr: 12211

jankeromnes pushed a commit to jankeromnes/gecko that referenced this pull request Aug 4, 2018

Bug 1478998 [wpt PR 12211] - Fold "Unscopable handled correctly" test…
…s into the attribute/operation tests, a=testonly

Automatic update from web-platform-testsFold "Unscopable handled correctly" tests into the attribute/operation tests (#12211)

The `[Unscopable]` checks were added here:
web-platform-tests/wpt#9490

However, this extended attribute is very rarely used, currently only
in DOM and Fullscreen. And yet, every property and operation generates
a test like this, which is normally passing, example:
https://wpt.fyi/results/compat/interfaces.any.html

Just fold these into the existing tests for attributes/operations like
the many other aspects already covered. Because of the
"do_interface_attribute_asserts must be the last thing" problem,
there's a change of structure for the attribute test.
--

wpt-commits: 2f8b11a39d4da8d729903b1b30557a875d5bf76a
wpt-pr: 12211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.