Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom-elements: Support cloneNode() for customized built-in elements #9491

Merged
merged 1 commit into from Feb 13, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 13, 2018

Element::CloneElementWithoutAttributesAndChildren() should use "create
an element" algorithm with |is| value.

Note that a change in SVGScriptElement.cpp isn't necessary because
Custom Elements V1 doesn't support SVG elements. This CL updates
SVGScriptElement.cpp for consistency and clean code.

WPT: Add cloneNode() tests to custom-elements/builtin-coverage.html.

Bug: 807871
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Iaa7d2781b916e2459ee244540d619cfffcf42427
Reviewed-on: https://chromium-review.googlesource.com/915401
Commit-Queue: Kent Tamura tkent@chromium.org
Reviewed-by: Yoichi Osato yoichio@chromium.org
Cr-Commit-Position: refs/heads/master@{#536297}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 13, 2018

Build PASSED

Started: 2018-02-13 09:00:43
Finished: 2018-02-13 09:05:08

Failing Jobs

  • chrome:dev
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-915401 branch from b07f057 to 5abae15 Feb 13, 2018

custom-elements: Support cloneNode() for customized built-in elements
Element::CloneElementWithoutAttributesAndChildren() should use "create
an element" algorithm with |is| value.

Note that a change in SVGScriptElement.cpp isn't necessary because
Custom Elements V1 doesn't support SVG elements. This CL updates
SVGScriptElement.cpp for consistency and clean code.

WPT: Add cloneNode() tests to custom-elements/builtin-coverage.html.

Bug: 807871
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Iaa7d2781b916e2459ee244540d619cfffcf42427
Reviewed-on: https://chromium-review.googlesource.com/915401
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536297}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-915401 branch from 5abae15 to 31c2450 Feb 13, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 57780df into master Feb 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-915401 branch Feb 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.