Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set WasFetchedViaServiceWorker for multipart image response #9492

Merged
merged 1 commit into from Feb 19, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 13, 2018

When creating a ResourceResponse from another ResourceResponse,
we need to copy WasFetchedViaServiceWorker and
ResponseTypeViaServiceWorker.

Bug: 737648
Change-Id: I9405738221ef5232e235f9fc400f204b7b558596
Reviewed-on: https://chromium-review.googlesource.com/907012
Commit-Queue: Kenichi Ishibashi bashi@chromium.org
Reviewed-by: Yutaka Hirano yhirano@chromium.org
Reviewed-by: Matt Falkenhagen falken@chromium.org
Cr-Commit-Position: refs/heads/master@{#537579}


This change is Reviewable

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 13, 2018

Build PASSED

Started: 2018-02-19 05:35:45
Finished: 2018-02-19 05:40:33

Failing Jobs

  • chrome:dev

Unstable Results

Browser: "Chrome Dev" (failures allowed)

View in: WPT PR Status | TravisCI

Test Subtest Results Messages
/service-workers/service-worker/multipart-image.https.html   OK: 10
  cross-origin multipart image via SW with approved CORS should be readable PASS: 7
FAIL: 3
assert_equals: expected 255 but got 0
  cross-origin multipart image via SW with rejected CORS should fail to load PASS: 10
  cross-origin multipart image with no-cors via SW should not be readable PASS: 10
  initialize global state PASS: 10
  restore global state PASS: 10
  same-origin multipart image via SW should be readable PASS: 7
FAIL: 3
assert_equals: expected 255 but got 0

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-907012 branch 10 times, most recently from 7260c67 to db8dd21 Feb 13, 2018

Set WasFetchedViaServiceWorker for multipart image response
When creating a ResourceResponse from another ResourceResponse,
we need to copy WasFetchedViaServiceWorker and
ResponseTypeViaServiceWorker.

Bug: 737648
Change-Id: I9405738221ef5232e235f9fc400f204b7b558596
Reviewed-on: https://chromium-review.googlesource.com/907012
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537579}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-907012 branch from db8dd21 to 4fd2f1a Feb 19, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 75c962d into master Feb 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-907012 branch Feb 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.