Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LayoutNG] Allow zero-width layout opportunities. #9503

Merged
merged 1 commit into from Feb 15, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 13, 2018

Zero-width floats or in-flow block-level objects that establish a new formatting
context may fit beside preceding floats even if there's zero inline space left.

With this change, a couple of tests start passing, but coverage seems a
bit low, so I added a few new ones.

Had to rebaseline fast/text/word-break.html because a zero-width line
may now fit beside a float that takes up all available inline
space. There was a
in the test that used to insert the
line below such a float. We're now compatible with the others (and our
old selves).

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Iaf394b7039545eea235b2841457f1662e5890ba9
Reviewed-on: https://chromium-review.googlesource.com/916262
Commit-Queue: Morten Stenshorne mstensho@chromium.org
Reviewed-by: Ian Kilpatrick ikilpatrick@chromium.org
Reviewed-by: Koji Ishii kojii@chromium.org
Cr-Commit-Position: refs/heads/master@{#537000}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 13, 2018

Build PASSED

Started: 2018-02-15 13:35:23
Finished: 2018-02-15 13:43:08

Failing Jobs

  • chrome:dev
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-916262 branch 2 times, most recently from 0e6cb2b to 465bd74 Feb 14, 2018

[LayoutNG] Allow zero-width layout opportunities.
Zero-width floats or in-flow block-level objects that establish a new formatting
context may fit beside preceding floats even if there's zero inline space left.

With this change, a couple of tests start passing, but coverage seems a
bit low, so I added a few new ones.

Had to rebaseline fast/text/word-break.html because a zero-width line
may now fit beside a float that takes up all available inline
space. There was a <br clear=all> in the test that used to insert the
line below such a float. We're now compatible with the others (and our
old selves).

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Iaf394b7039545eea235b2841457f1662e5890ba9
Reviewed-on: https://chromium-review.googlesource.com/916262
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537000}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-916262 branch from 465bd74 to cb130c7 Feb 15, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit e2b2513 into master Feb 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-916262 branch Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.