Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[custom-elements] Some fixes for "is" attribute behavior changes #9505

Merged
merged 1 commit into from Feb 14, 2018

Conversation

@tkent-google
Copy link
Contributor

tkent-google commented Feb 14, 2018

This is for whatwg/dom#566.

  • document.createElement() and createElementNS() don't add "is" content
    attribute.

  • cloneNode() should clone custom elements even if they have no "is"
    content attributes or have "is" content attribute inconsistent with
    "is value."

[custom-elements] Some fixes for "is" attribute behavior changes
This is for whatwg/dom#566.

- document.createElement() and createElementNS() don't add "is" content
 attribute.

- cloneNode() should clone custom elements even if they have no "is"
 content attributes or have "is" content attribute inconsistent with
 "is value."
@domenic
Copy link
Member

domenic left a comment

These LGTM, thanks. You're planning on landing the HTML serialization changes/tests separately?

@tkent-google

This comment has been minimized.

Copy link
Contributor Author

tkent-google commented Feb 14, 2018

You're planning on landing the HTML serialization changes/tests separately?

Right.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 14, 2018

Build PASSED

Started: 2018-02-14 00:12:10
Finished: 2018-02-14 00:25:24

Failing Jobs

  • chrome:dev
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

domenic added a commit to whatwg/dom that referenced this pull request Feb 14, 2018

Change handling of is="" in element creation and cloning
Part of fixing whatwg/html#3402. This changes two things:

* It fixes the cloning steps to consult the internal is value, instead of the is="" content attribute.
* It removes the step from createElement()/createElementNS() that would insert an is="" attribute in the created element, as we've now decided that is="" is a way of communicating to the parser, and not a general-purpose indicator of customized built-in-ness.

See also whatwg/html#3444 for the other half of the fix.

Tests: web-platform-tests/wpt#9505

@domenic domenic merged commit 1e4fe87 into master Feb 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tkent-google tkent-google deleted the tkent-dom-is-attr branch Feb 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.