Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] Refactor the per-property test harness. #9507

Merged
merged 1 commit into from Feb 14, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 14, 2018

This patch refactors the per-property test harness quite
a bit to deal with property specific behaviour:

  • We allow tests to override the expectation/asserts
    for specified and computed values. So it means that a
    property might compute 'auto' to '0px' and we can easily
    assert that by passing a callback to 'computed'.

  • We moved margin-top to margin and test all the margin
    properties (except the margin shorthand).

  • We made margin properties work by setting the correct
    metadata in the CSSProperties.json5.

  • We removed unitless zero tests. They don't seem to
    be required by the spec.

Bug: 774887
Change-Id: I08605ac6af01576ff9f6c878c2ca9e280c9948e1
Reviewed-on: https://chromium-review.googlesource.com/915884
Reviewed-by: nainar nainar@chromium.org
Commit-Queue: Darren Shen shend@chromium.org
Cr-Commit-Position: refs/heads/master@{#536603}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 14, 2018

Build PASSED

Started: 2018-02-14 02:15:59
Finished: 2018-02-14 02:20:13

Failing Jobs

  • chrome:dev
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

[css-typed-om] Refactor the per-property test harness.
This patch refactors the per-property test harness quite
a bit to deal with property specific behaviour:

- We allow tests to override the expectation/asserts
  for specified and computed values. So it means that a
  property might compute 'auto' to '0px' and we can easily
  assert that by passing a callback to 'computed'.

- We moved margin-top to margin and test all the margin
  properties (except the margin shorthand).

- We made margin properties work by setting the correct
  metadata in the CSSProperties.json5.

- We removed unitless zero tests. They don't seem to
  be required by the spec.

Bug: 774887
Change-Id: I08605ac6af01576ff9f6c878c2ca9e280c9948e1
Reviewed-on: https://chromium-review.googlesource.com/915884
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536603}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-915884 branch from 6be85c3 to 4b7b56b Feb 14, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 5479ebe into master Feb 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-915884 branch Feb 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.