Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] Move inline style map layout tests to WPT. #9511

Merged
merged 1 commit into from Feb 14, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 14, 2018

We used to have some inline style map layout tests for a subset of
properties. This patch moves them to WPT using the new test harness.

Fixed some bugs involving properties not given the correct metadata
(e.g. border-style should not take an ).

Transform is failing tests because it should compute to as specified
but it's computing to 'none' (will fix this later).

TODO in follow up patches:

  • Test list-valued properties properly.
  • Add more test examples to and .

Bug: 774887
Change-Id: I93f20a457e2220329b661787c7d557ee28b1f62d
Reviewed-on: https://chromium-review.googlesource.com/917921
Reviewed-by: nainar nainar@chromium.org
Commit-Queue: Darren Shen shend@chromium.org
Cr-Commit-Position: refs/heads/master@{#536658}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 14, 2018

Build PASSED

Started: 2018-02-14 06:08:39
Finished: 2018-02-14 06:18:48

Failing Jobs

  • chrome:dev
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

[css-typed-om] Move inline style map layout tests to WPT.
We used to have some inline style map layout tests for a subset of
properties. This patch moves them to WPT using the new test harness.

Fixed some bugs involving properties not given the correct metadata
(e.g. border-style should not take an <image>).

Transform is failing tests because it should compute to as specified
but it's computing to 'none' (will fix this later).

TODO in follow up patches:
- Test list-valued properties properly.
- Add more test examples to <position> and <image>.

Bug: 774887
Change-Id: I93f20a457e2220329b661787c7d557ee28b1f62d
Reviewed-on: https://chromium-review.googlesource.com/917921
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536658}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-917921 branch from 52d1a5a to a9bc21e Feb 14, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 783faf5 into master Feb 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-917921 branch Feb 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.