Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make WPT webrtc/simplecall.html pass #9516

Merged
merged 1 commit into from Feb 15, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 14, 2018

The test was failing because passing a null ("end of candidates")
candidate to addIceCandidate is not permitted.

Spec link:

https://www.w3.org/TR/webrtc/#dom-rtcpeerconnection-addicecandidate
https://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-addicecandidate

Bug: none
Change-Id: I1f22d27393a482a882ebe9735488d8cb723b6e75
Reviewed-on: https://chromium-review.googlesource.com/918662
Reviewed-by: Henrik Boström hbos@chromium.org
Commit-Queue: Harald Alvestrand hta@chromium.org
Cr-Commit-Position: refs/heads/master@{#536977}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 14, 2018

Build PASSED

Started: 2018-02-15 09:45:25
Finished: 2018-02-15 09:51:24

Failing Jobs

  • chrome:dev
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-918662 branch from 4b8d464 to e4afd3e Feb 14, 2018

Make WPT webrtc/simplecall.html pass
The test was failing because passing a null ("end of candidates")
candidate to addIceCandidate is not permitted.

Spec link:

https://www.w3.org/TR/webrtc/#dom-rtcpeerconnection-addicecandidate
https://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-addicecandidate

Bug: none
Change-Id: I1f22d27393a482a882ebe9735488d8cb723b6e75
Reviewed-on: https://chromium-review.googlesource.com/918662
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536977}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-918662 branch from e4afd3e to 9218274 Feb 15, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 49d8cd2 into master Feb 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-918662 branch Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.