Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebRTC: Add test for null ICE candidate #9517

Conversation

@alvestrand
Copy link
Contributor

alvestrand commented Feb 14, 2018

The spec does not seem to allow for a null ICE candidate, and
explicitly test for presence of mid or midx attributes.

This should mean that a null ICE candidate is a type error.

New test presently passes on Chrome, fails on Firefox.

WebRTC: Add test for null ICE candidate
The spec does not seem to allow for a null ICE candidate, and
explicitly test for presence of mid or midx attributes.

This should mean that a null ICE candidate is a type error.

New test presently passes on Chrome, fails on Firefox.
@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 14, 2018

Build ERRORED

Started: 2018-03-15 09:53:16
Finished: 2018-03-15 10:10:11

Failing Jobs

  • firefox:nightly
  • chrome:dev
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@alvestrand

This comment has been minimized.

Copy link
Contributor Author

alvestrand commented Feb 14, 2018

Can't quite figure out why the Firefox run complains. Yes, it has a new failing test. Yes, that was expected.

@fippo

This comment has been minimized.

Copy link
Contributor

fippo commented Feb 14, 2018

I continue to disagree with the spec on this but the test describes what is in the spec. @jan-ivar might have an opinion as well ;-)

@fippo

fippo approved these changes Mar 12, 2018

@soareschen

This comment has been minimized.

Copy link
Contributor

soareschen commented Mar 15, 2018

@jan-ivar

This comment has been minimized.

Copy link
Contributor

jan-ivar commented Mar 15, 2018

This is a known bug in Firefox.

@alvestrand

This comment has been minimized.

Copy link
Contributor Author

alvestrand commented Apr 26, 2018

Yes, this is already tested. Don't know why I didn't see this. Closing.

@alvestrand alvestrand closed this Apr 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.