Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test box-shadow serialization #9519

Merged
merged 2 commits into from Apr 10, 2018

Conversation

Projects
None yet
5 participants
@csnardi
Copy link
Member

csnardi commented Feb 14, 2018

Following w3c/csswg-drafts#2305, the canonical serialization for box-shadow was changed from inset? && <length>{2,4} && <color>? to <color>? && <length>{2,4} && inset?. Convert an existing box-shadow text into a testharness.js test in order to test serialization as well.

I added parsing-testcommon.js as a copy of https://github.com/w3c/web-platform-tests/blob/master/css/css-transforms/parsing/resources/parsing-testcommon.js (this should probably be moved into a css/resources directory), and also renamed the file as it seems the testharness reporting does not play nicely with XHTML (it had no styling).

@csnardi

This comment has been minimized.

Copy link
Member Author

csnardi commented Feb 14, 2018

@fantasai Since you made the edits and originally wrote this test, could you take a look?

Test box-shadow serialization
Following w3c/csswg-drafts#2305, the canonical serialization for box-shadow was changed from inset? && <length>{2,4} && <color>? to <color>? && <length>{2,4} && inset?. Convert an existing box-shadow text into a testharness.js test in order to test serialization as well.

@csnardi csnardi force-pushed the csnardi:box-shadow-serialization branch from b5e246e to 8e9f916 Feb 14, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 14, 2018

Build PENDING

Started: None
Finished: None

View more information about this build on:

@fantasai

This comment has been minimized.

Copy link
Contributor

fantasai commented Apr 9, 2018

I defer to @gsnedders on this one.

@gsnedders

This comment has been minimized.

Copy link
Contributor

gsnedders commented Apr 9, 2018

also renamed the file as it seems the testharness reporting does not play nicely with XHTML (it had no styling)

Hmm, that's odd; it should definitely work. http://w3c-test.org/css/cssom-view/media-query-list-interface.xht for example looks fine here? And having copied and renamed your file it works too once I add in the optional tags?

Otherwise this LGTM.

@csnardi

This comment has been minimized.

Copy link
Member Author

csnardi commented Apr 10, 2018

@gsnedders Huh, I probably just messed up something then. Should I change this back to XHTML, or leave it as-is?

@gsnedders gsnedders merged commit 5a93530 into web-platform-tests:master Apr 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gsnedders

This comment has been minimized.

Copy link
Contributor

gsnedders commented Apr 10, 2018

@csnardi No need; not sure why I didn't merge before?

@csnardi csnardi deleted the csnardi:box-shadow-serialization branch Apr 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.