Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotations to wptrunner #9521

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@gsnedders
Copy link
Contributor

gsnedders commented Feb 14, 2018

These are based on annotations generated by pyannotate.

Todo:

  • Make tests pass again
  • Add mypy --py2 to wptrunner tox
  • Get mypy passing

This change is Reviewable

@wpt-pr-bot wpt-pr-bot added the infra label Feb 14, 2018

@wpt-pr-bot wpt-pr-bot requested a review from jgraham Feb 14, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 14, 2018

Build BROKEN

Started: 2018-02-14 19:52:40
Finished: 2018-02-14 20:00:53

Failing Jobs

  • tools_unittest in py27
  • tools_unittest in pypy
  • wpt_integration in py27,py27-flake8
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@gsnedders gsnedders closed this May 21, 2018

@gsnedders

This comment has been minimized.

Copy link
Contributor Author

gsnedders commented May 21, 2018

Closing in favour of starting elsewhere. (Let's get manifest and lint passing first.)

@sideshowbarker sideshowbarker deleted the wptrunner-mypy branch Nov 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.