Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port another set of sticky tests to JS rather than reftests #9523

Merged
merged 1 commit into from Feb 21, 2018

Conversation

Projects
None yet
6 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 14, 2018

Change-Id: Idf6dd882d2d50b1ec349f245d76717553ee266b3
Reviewed-on: https://chromium-review.googlesource.com/882002
Reviewed-by: Robert Flack flackr@chromium.org
Commit-Queue: Stephen McGruer smcgruer@chromium.org
Cr-Commit-Position: refs/heads/master@{#532966}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 14, 2018

Build PASSED

Started: 2018-02-21 13:04:54
Finished: 2018-02-21 13:15:58

Failing Jobs

  • MicrosoftEdge:16.16299

Unstable Results

Browser: "Microsoftedge 16.16299" (failures allowed)

View in: WPT PR Status | TravisCI

Test Subtest Results Messages
/css/css-position/position-sticky-transforms.html   TIMEOUT: 1
OK: 9
  Perspective transforms are carried out on the stuck element position FAIL: 9
assert_equals: expected 25 but got NaN
  Rotate transforms are carried out on the stuck element position FAIL: 9
assert_equals: expected 75 but got NaN
  Scale transforms are carried out on the stuck element position PASS: 9
@kereliuk

This comment has been minimized.

Copy link
Contributor

kereliuk commented Feb 15, 2018

Restarting the Travis build

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Feb 21, 2018

Restarting again.

@foolip foolip force-pushed the chromium-export-9131091495 branch from 24628d8 to 8236302 Feb 21, 2018

foolip added a commit that referenced this pull request Feb 21, 2018

Update reftests in manifest when reftests become non-reftests
In #9523 some tests were
converted from reftests to testharness, but the incremental manifest
update mechanism doesn't handle this case. This appears to be the cause
of the mysterious Travis failures on that PR.

foolip added a commit that referenced this pull request Feb 21, 2018

Update reftests in manifest when reftests become non-reftests
In #9523 some tests were
converted from reftests to testharness, but the incremental manifest
update mechanism doesn't handle this case. This appears to be the cause
of the mysterious Travis failures on that PR.
@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Feb 21, 2018

Seems like the problem is a manifest update bug, trying to fix in #9598.

Port another set of sticky tests to JS rather than reftests
Change-Id: Idf6dd882d2d50b1ec349f245d76717553ee266b3
Reviewed-on: https://chromium-review.googlesource.com/882002
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532966}

@foolip foolip force-pushed the chromium-export-9131091495 branch from 8236302 to 189b38b Feb 21, 2018

foolip added a commit that referenced this pull request Feb 21, 2018

Update reftests in manifest when reftests become non-reftests (#9598)
In #9523 some tests were
converted from reftests to testharness, but the incremental manifest
update mechanism doesn't handle this case. This appears to be the cause
of the mysterious Travis failures on that PR.

The added test failed without the code changes.
@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Feb 21, 2018

It worked, yay!

@foolip foolip merged commit c67d9e1 into master Feb 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@foolip foolip deleted the chromium-export-9131091495 branch Feb 21, 2018

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Feb 22, 2018

FYI, I've filed https://bugs.chromium.org/p/chromium/issues/detail?id=814617 about an oddity in export involving this PR.

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Feb 22, 2018

This is being reverted in #9625, by exporting the revert in Chromium.

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Apr 1, 2018

Bug 1439853 [wpt PR 9598] - Update reftests in manifest when reftests…
… become non-reftests, a=testonly

Automatic update from web-platform-testsUpdate reftests in manifest when reftests become non-reftests (#9598)

In web-platform-tests/wpt#9523 some tests were
converted from reftests to testharness, but the incremental manifest
update mechanism doesn't handle this case. This appears to be the cause
of the mysterious Travis failures on that PR.

The added test failed without the code changes.

wpt-commits: 86195076e37a960ff44fa86edc54699455f3a4aa
wpt-pr: 9598
wpt-commits: 86195076e37a960ff44fa86edc54699455f3a4aa
wpt-pr: 9598

mykmelez pushed a commit to mozilla/gecko that referenced this pull request Apr 2, 2018

Bug 1439853 [wpt PR 9598] - Update reftests in manifest when reftests…
… become non-reftests, a=testonly

Automatic update from web-platform-testsUpdate reftests in manifest when reftests become non-reftests (#9598)

In web-platform-tests/wpt#9523 some tests were
converted from reftests to testharness, but the incremental manifest
update mechanism doesn't handle this case. This appears to be the cause
of the mysterious Travis failures on that PR.

The added test failed without the code changes.

wpt-commits: 86195076e37a960ff44fa86edc54699455f3a4aa
wpt-pr: 9598
wpt-commits: 86195076e37a960ff44fa86edc54699455f3a4aa
wpt-pr: 9598
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.