Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for the breaking of a multicolumn across columns, including backgrounds and column rules #9527

Merged
merged 1 commit into from Feb 15, 2018

Conversation

Projects
None yet
4 participants
@dbaron
Copy link
Member

dbaron commented Feb 14, 2018

The *-nobackground-* tests pass in Firefox and Chrome, and the others
pass in Chrome and fail in Firefox due to what I (as a Gecko
implementor) consider to be a Firefox bug. I haven't yet tested other
engines.

Given the level of ambiguity in the multicol spec, I suspect these tests
probably test some things that aren't formally specified. However, I
think that's probably OK for now. One issue that I know of that they
depend on the spec for is w3c/csswg-drafts#2309.

Add tests for the breaking of a multicolumn across columns, including…
… backgrounds and column rules.

The *-nobackground-* tests pass in Firefox and Chrome, and the others
pass in Chrome and fail in Firefox due to what I (as a Gecko
implementor) consider to be a Firefox bug.  I haven't yet tested other
engines.

Given the level of ambiguity in the multicol spec, I suspect these tests
probably test some things that aren't formally specified.  However, I
think that's probably OK for now.  One issue that I know of that they
depend on the spec for is w3c/csswg-drafts#2309.

@dbaron dbaron force-pushed the dbaron:multicol-breaking branch from 43ac9cc to edfa2f6 Feb 14, 2018

@dbaron

This comment has been minimized.

Copy link
Member Author

dbaron commented Feb 14, 2018

Er, sorry, the 003 variant doesn't pass in Firefox even in the nobackground set, due to another Gecko bug.

Also, I'd note that the nobackground set tests strictly less than the others, but I'd like them there because they serve as regression tests for the current parts that do work in Firefox.

@dbaron

This comment has been minimized.

Copy link
Member Author

dbaron commented Feb 14, 2018

And I'd note these tests originated in my review of bug 1346983.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 14, 2018

Build PASSED

Started: 2018-02-14 22:54:19
Finished: 2018-02-14 23:06:55

Failing Jobs

  • chrome:dev
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@dbaron dbaron merged commit d04c0d5 into web-platform-tests:master Feb 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.