Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[USVString] Apply USVString into RTCDataChannel.send #9530

Merged
merged 1 commit into from Feb 15, 2018

Conversation

Projects
None yet
3 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 14, 2018

Latest spec changed DOMString type of send with USVString.

This CL applies USVString type into the RTCDataCchannel.send according to the spec.

Bug: 790860
Change-Id: I3d2e3fef8e6a8cc8ca94a8ae18c2ccb7dcc48016
Reviewed-on: https://chromium-review.googlesource.com/917741
Reviewed-by: Takeshi Yoshino tyoshino@chromium.org
Reviewed-by: Tommi tommi@chromium.org
Commit-Queue: Tommi tommi@chromium.org
Cr-Commit-Position: refs/heads/master@{#537015}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 14, 2018

Build PASSED

Started: 2018-02-15 15:01:07
Finished: 2018-02-15 15:07:09

Failing Jobs

  • safari:11.0

View more information about this build on:

[USVString] Apply USVString into RTCDataChannel.send
Latest spec changed DOMString type of send with USVString.
 - https://w3c.github.io/webrtc-pc/#dom-rtcdatachannel

This CL applies USVString type into the RTCDataCchannel.send according to the spec.

Bug: 790860
Change-Id: I3d2e3fef8e6a8cc8ca94a8ae18c2ccb7dcc48016
Reviewed-on: https://chromium-review.googlesource.com/917741
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Commit-Queue: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537015}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-917741 branch from 5f562d4 to 5bd8355 Feb 15, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 1a3951e into master Feb 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-917741 branch Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.