Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1436659] Rename tests in timing-model/animations to match spec section titles; #9531

Merged
merged 8 commits into from Feb 16, 2018

Conversation

Projects
None yet
5 participants
@moz-wptsync-bot
Copy link
Collaborator

moz-wptsync-bot commented Feb 15, 2018

In this folder we have a mixture of tests named after the procedure they are
testing or the section that contains the procedure. The latter seems to be more
common and makes it a little easier to check that all sections are tested so
this patch renames files to refer to the section titles instead. It also updates
a few of the test file titles and URLs.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1436659
gecko-commit: 0634cd8f08ebe0905a9188fb1398c7b5f889c5dc
gecko-integration-branch: autoland
gecko-reviewers: hiro

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 15, 2018

Build ERRORED

Started: 2018-02-15 10:02:26
Finished: 2018-02-15 10:17:21

Failing Jobs

  • tools_unittest in pypy
  • chrome:dev
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@birtles

This comment has been minimized.

Copy link
Contributor

birtles commented Feb 15, 2018

I can only assume the "nightly" being used here is pre Gecko bug 1422248 (i.e. Firefox 59 or earlier) and we happen to pass it on the first pass because the initial cold startup time means that the three frames tick before we run the "microtask" (that last part doesn't quite sound right, but it might be something of that nature).

@birtles

This comment has been minimized.

Copy link
Contributor

birtles commented Feb 15, 2018

@jgraham @gsnedders Can you help here? This seems to be running against an old version of Firefox.

Furthermore, the unstable test is not new in this PR.

birtles added some commits Feb 15, 2018

Rename tests in timing-model/animations to match spec section titles;
In this folder we have a mixture of tests named after the procedure they are
testing or the section that contains the procedure. The latter seems to be more
common and makes it a little easier to check that all sections are tested so
this patch renames files to refer to the section titles instead. It also updates
a few of the test file titles and URLs.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1436659
gecko-commit: 0634cd8f08ebe0905a9188fb1398c7b5f889c5dc
gecko-integration-branch: autoland
gecko-reviewers: hiro
Use async/await in timing-model/animations tests;
Using async/await makes these tests easier to read and appears to be supported
in all browsers now. This patch updates the tests in
web-animations/timing-model/animations since we will update these tests later in
this patch series and it will be easier if we convert them to using async first.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1436659
gecko-commit: c8ee4a012dae506ae06bb5b2ad50942b04c1aaaa
gecko-integration-branch: autoland
gecko-reviewers: hiro
Move playback rate test to timing-model;
The test under web-animations/interfaces/Animation/playbackRate.html is really
testing the timing model so this patch moves it there. We'll simplify it in the
next patch.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1436659
gecko-commit: c2c352456a4cf62dcc12f851138b04397675a445
gecko-integration-branch: autoland
gecko-reviewers: hiro
Simplify playback rate setting test;
I didn't like the way these tests were written so I decided to rewrite them to
make it more clear what they are trying to test.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1436659
gecko-commit: b93a8879555d2fa7e7d4e00a275513a3a6338b35
gecko-integration-branch: autoland
gecko-reviewers: hiro
Move finishing tests to timing-model;
These tests are not testing the interface so much as the 'finish an animation'
procedure.

This patch simply moves the tests as-is. They will be simplified in the next
patch in this series.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1436659
gecko-commit: b86e1331cb36634fd33677043b61fc0c1d8485bc
gecko-integration-branch: autoland
gecko-reviewers: hiro
Tidy up tests for "finishing an animation";
These patches update these tests as follows:

* Used async/await where it simplifies the tests
* Updated the test descriptions to reflect what they are testing in the timing
  model
* Fixed a couple of bugs where we set the playbackRate on a pause-pending
  animation (which causes it to no longer be pause-pending).

In the process I noticed a couple of tests that don't really belong here. They
will be moved in the next patch.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1436659
gecko-commit: 44ddf14fd3346658c3223f13652073fafbfa48fa
gecko-integration-branch: autoland
gecko-reviewers: hiro
Further divide up finishing tests;
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1436659
gecko-commit: a1a5840a6bb53e305ba02bcbeb215659342d0edb
gecko-integration-branch: autoland
gecko-reviewers: hiro
Add tests for Animation.updatePlaybackRate;
These tests test the behavior introduced in the following changesets to the Web
Animations specification:

  1. w3c/csswg-drafts@5af5e27
  2. w3c/csswg-drafts@673f6fc

which can be viewed as a merged diff at:

  https://gist.github.com/birtles/d147eb2e0e2d4d37fadf217abd709411

See the following spec issues:

  1. w3c/csswg-drafts#2059
  2. w3c/csswg-drafts#2266
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1436659
gecko-commit: 7465cb110ae5ec2e2ca73182caf5293f0efc8fd5
gecko-integration-branch: autoland
gecko-reviewers: hiro

@moz-wptsync-bot moz-wptsync-bot force-pushed the gecko/sync/upstream/open/1436659/1 branch from 0682ed5 to d99e6f6 Feb 15, 2018

@sideshowbarker sideshowbarker merged commit e60dd14 into master Feb 16, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
upstream/gecko Landed on mozilla-central
Details

@sideshowbarker sideshowbarker deleted the gecko/sync/upstream/open/1436659/1 branch Feb 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.