Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS2 tests were only correct if the default font has two weights. #9533

Merged
merged 2 commits into from Feb 15, 2018

Conversation

Projects
None yet
4 participants
@faceless2
Copy link
Contributor

faceless2 commented Feb 15, 2018

font-weight-rule 005 and 007 both made the incorrect assumption that there were no weights lighter than 400 or greater than 700 in the default font.

Added new reference tests for them which don't depend on this.

Mike
font-weight-rule 005 and 007 both made the incorrect
assumption that there were no weights lighter than 100
or greater than 400 in the default font. Added new
reference tests for them which don't depend on that.
<!DOCTYPE html>
<meta charset="utf-8">
<title>CSS Reference</title>
<link rel="author" title="Intel" href="http://www.intel.com">

This comment has been minimized.

Copy link
@dbaron

dbaron Feb 15, 2018

Member

Seems like this should be you rather than Intel. (Same for the other file.)

<title>CSS Reference</title>
<link rel="author" title="Intel" href="http://www.intel.com">
<style>
div { font-weight: 100 }

This comment has been minimized.

Copy link
@dbaron

dbaron Feb 15, 2018

Member

This needs to be 900 rather than 100!

Mike
@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 15, 2018

Build PASSED

Started: 2018-02-15 01:17:12
Finished: 2018-02-15 01:24:01

Failing Jobs

  • chrome:dev
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@dbaron

dbaron approved these changes Feb 15, 2018

@dbaron dbaron merged commit 30c492f into web-platform-tests:master Feb 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dbaron

This comment has been minimized.

Copy link
Member

dbaron commented Feb 15, 2018

(I fixed up the commit message a bit when I merged.)

@faceless2 faceless2 deleted the faceless2:bfo-css2-font-weight-fix branch Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.