Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for empty URL behaviour #9534

Merged
merged 1 commit into from Feb 15, 2018

Conversation

Projects
None yet
4 participants
@gsnedders
Copy link
Contributor

gsnedders commented Feb 15, 2018

Tests for the WG resolution in w3c/csswg-drafts#2211 (comment)

@gsnedders gsnedders force-pushed the gsnedders:empty-url branch from 8e7a526 to e883684 Feb 15, 2018

@dbaron

dbaron approved these changes Feb 15, 2018

for (let id of ids) {
test(function() {
const el = document.getElementById(id);
const expected = id.startsWith("inline-") ? inline_url : external_url;

This comment has been minimized.

Copy link
@dbaron

dbaron Feb 15, 2018

Member

I'd note that you could have generated this in more interesting ways, e.g.,

const expected = window[id.replace(/-.*/, "_url")];

although whether that's a good idea is an open question... (Though it would have required var rather than const, or putting the expected values on a different object rather than using window.)

It's certainly fine as it is.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 15, 2018

Build PASSED

Started: 2018-02-15 01:05:19
Finished: 2018-02-15 01:16:01

Failing Jobs

  • chrome:dev
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@dbaron dbaron merged commit 9b0130b into web-platform-tests:master Feb 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gsnedders gsnedders deleted the gsnedders:empty-url branch Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.