Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we always run against the latest version of Firefox. #9537

Merged
merged 1 commit into from Feb 21, 2018

Conversation

Projects
None yet
4 participants
@jgraham
Copy link
Contributor

jgraham commented Feb 15, 2018

Previously we were downloading a version by looking for the first
match of the supplied regexp on the download page. That doesn't work
well in general and we need to look through the listings for the
version with the highest number.


This change is Reviewable

@jgraham jgraham requested a review from gsnedders Feb 15, 2018

@wpt-pr-bot wpt-pr-bot added the infra label Feb 15, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 15, 2018

Build PASSED

Started: 2018-02-16 19:52:03
Finished: 2018-02-16 20:05:56

View more information about this build on:

@gsnedders

This comment has been minimized.

Copy link
Contributor

gsnedders commented Feb 15, 2018

Can we have a test to ensure we have the right behaviour here?

@jgraham jgraham force-pushed the firefox_version branch from d58180a to f412cb7 Feb 15, 2018

Ensure we always run against the latest version of Firefox.
Previously we were downloading a version by looking for the first
match of the supplied regexp on the download page. That doesn't work
well in general and we need to look through the listings for the
version with the highest number.

@jgraham jgraham force-pushed the firefox_version branch from f412cb7 to fe5d16d Feb 16, 2018

@gsnedders gsnedders merged commit 9d8895d into master Feb 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gsnedders gsnedders deleted the firefox_version branch Feb 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.