Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LayoutNG] Don't add zero-width floats to the exclusion space. #9538

Merged
merged 1 commit into from Feb 16, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 15, 2018

The only thing such floats should affect is the block position of
subsequent floats (float rule §5 [1] and clearance). They should not
affect the inline position or inline size of subsequent floats or new
formatting contexts.

The spec isn't actually clear here, although the browsers agree on the
above. Submitted w3c/csswg-drafts#2312

[1] https://www.w3.org/TR/CSS22/visuren.html#float-position

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ia9e724c8a58fcb017f86f26bdf90394f09414f4e
Reviewed-on: https://chromium-review.googlesource.com/919065
Reviewed-by: Ian Kilpatrick ikilpatrick@chromium.org
Commit-Queue: Morten Stenshorne mstensho@chromium.org
Cr-Commit-Position: refs/heads/master@{#537274}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 15, 2018

Build PASSED

Started: 2018-02-16 10:31:14
Finished: 2018-02-16 10:37:00

Failing Jobs

  • chrome:dev
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

[LayoutNG] Don't add zero-width floats to the exclusion space.
The only thing such floats should affect is the block position of
subsequent floats (float rule §5 [1] and clearance). They should not
affect the inline position or inline size of subsequent floats or new
formatting contexts.

The spec isn't actually clear here, although the browsers agree on the
above. Submitted w3c/csswg-drafts#2312

[1] https://www.w3.org/TR/CSS22/visuren.html#float-position

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ia9e724c8a58fcb017f86f26bdf90394f09414f4e
Reviewed-on: https://chromium-review.googlesource.com/919065
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537274}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-919065 branch from e9cda9c to 795e2f6 Feb 16, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit ae06fa4 into master Feb 16, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-919065 branch Feb 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.