Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8613: get codecov working again #9545

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@gsnedders
Copy link
Contributor

gsnedders commented Feb 15, 2018

Fixes #8613.


This change is Reviewable

@wpt-pr-bot wpt-pr-bot added the infra label Feb 15, 2018

@wpt-pr-bot wpt-pr-bot requested a review from jgraham Feb 15, 2018

@@ -16,12 +16,15 @@ deps =
pytest-catchlog

commands =
pytest --cov {posargs}
pytest {posargs:--cov-config={toxinidir}/../.coveragerc --cov}

This comment has been minimized.

Copy link
@gsnedders

gsnedders Feb 15, 2018

Author Contributor

Well this is wrong.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 15, 2018

Build PASSED

Started: 2018-03-21 17:34:12
Finished: 2018-03-21 17:52:42

View more information about this build on:

@gsnedders gsnedders force-pushed the codecov branch from 05fb7f0 to 5b1ea1c Mar 5, 2018

@gsnedders gsnedders force-pushed the codecov branch from 5b1ea1c to 11ff441 Mar 21, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 21, 2018

Codecov Report

Merging #9545 into master will decrease coverage by 44.77%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #9545       +/-   ##
===========================================
- Coverage   87.22%   42.44%   -44.78%     
===========================================
  Files          24      129      +105     
  Lines        2419    14086    +11667     
  Branches      406     1914     +1508     
===========================================
+ Hits         2110     5979     +3869     
- Misses        240     7954     +7714     
- Partials       69      153       +84
Impacted Files Coverage Δ
tools/manifest/tests/test_sourcefile.py
tools/lint/lint.py
tools/manifest/utils.py
tools/manifest/__init__.py
tools/manifest/tests/test_XMLParser.py
tools/__init__.py
tools/conftest.py
tools/manifest/tests/test_manifest.py
tools/manifest/log.py
tools/manifest/manifest.py
... and 143 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbb38a6...b3ad93c. Read the comment docs.

@gsnedders gsnedders force-pushed the codecov branch from 703423a to b3ad93c Mar 21, 2018

@Ms2ger

Ms2ger approved these changes Mar 22, 2018

Copy link
Contributor

Ms2ger left a comment

Can't say much about the code, but this seems to work. Do squash.

@gsnedders

This comment has been minimized.

Copy link
Contributor Author

gsnedders commented Mar 26, 2018

https://codecov.io/gh/w3c/web-platform-tests/tree/b3ad93c2c75c553be65ccdc3427a6e4c705c8fcf is the latest built, and various things are broken, I think on the codecov.io side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.