Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WebAudio WPT tests that timeout. #9548

Merged
merged 1 commit into from Feb 20, 2018

Conversation

Projects
None yet
3 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 15, 2018

  • AudioParam IDL test:
    Actually add the IDL to the test. Also removed unused helpers.js.
  • MediaElementAudioSourceNode
    Fix error because the expected result is mono, so only has one channel.
    However, this still fails on bots because there's no audio hardware to
    drive the online context.

Bug: 626703
Test: the-audioparam-interface/idl-test.html
Change-Id: I987ad1219da1b6b6ef677f2923416634fa281d5f
Reviewed-on: https://chromium-review.googlesource.com/920261
Commit-Queue: Raymond Toy rtoy@chromium.org
Reviewed-by: Hongchan Choi hongchan@chromium.org
Cr-Commit-Position: refs/heads/master@{#537856}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 16, 2018

Build PASSED

Started: 2018-02-20 20:24:14
Finished: 2018-02-20 20:37:50

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-920261 branch from 40ee356 to 9d94e7d Feb 20, 2018

Fix WebAudio WPT tests that timeout.
- AudioParam IDL test:
  Actually add the IDL to the test.  Also removed unused helpers.js.
- MediaElementAudioSourceNode
  Fix error because the expected result is mono, so only has one channel.
  However, this still fails on bots because there's no audio hardware to
  drive the online context.

Bug: 626703
Test: the-audioparam-interface/idl-test.html
Change-Id: I987ad1219da1b6b6ef677f2923416634fa281d5f
Reviewed-on: https://chromium-review.googlesource.com/920261
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537856}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-920261 branch from 9d94e7d to 254d525 Feb 20, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 0d5ca04 into master Feb 20, 2018

1 of 2 checks passed

pyup.io/safety-ci html5lib 0.9999999 has known security vulnerabilities.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-920261 branch Feb 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.