Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-grid] Baseline alignment inside the tracks sizing algorithm #9553

Merged
merged 1 commit into from May 31, 2018

Conversation

Projects
None yet
6 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 16, 2018

We have identified several cases where the Baseline Alignment accounts
for the grid's intrinsic size. Since we depend on the track sizing
algorithm to compute the grid's intrinsic size, the only way to handle
all these cases is to integrate the baseline alignment logic in the
algorithm.

Additionally, the CSSWG has identified several cases that can't be
solved properly; such cases have in common that they imply cyclic
dependencies between the item's and grid area's size. The CSSWG has
resolved that these items don't participate in baseline alignment:

w3c/csswg-drafts#1365

There are also other related issues with some examples and relevant
discussions about this topic:

w3c/csswg-drafts#1039
w3c/csswg-drafts#1409

Bug: 704713
Change-Id: I817b16eb43aa76f4827deb8f1f20efb7fde3dc22
Reviewed-on: https://chromium-review.googlesource.com/923261
Commit-Queue: Javier Fernandez jfernandez@igalia.com
Reviewed-by: Sergio Villar svillar@igalia.com
Cr-Commit-Position: refs/heads/master@{#562406}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 16, 2018

Build PASSED

Started: 2018-03-19 23:25:59
Finished: 2018-03-19 23:34:40

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-923261 branch from 1bf32b5 to 386e310 Mar 7, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-923261 branch from 386e310 to c2cb4a4 Mar 19, 2018

@frivoal frivoal added the wg-css label Apr 30, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-923261 branch from c2cb4a4 to a106cf8 May 21, 2018

@wpt-pr-bot wpt-pr-bot added the support label May 21, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-923261 branch 3 times, most recently from 66b8190 to 0c786b2 May 22, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-923261 branch from 0c786b2 to 9d9ad90 May 29, 2018

[css-grid] Baseline alignment inside the tracks sizing algorithm
We have identified several cases where the Baseline Alignment accounts
for the grid's intrinsic size. Since we depend on the track sizing
algorithm to compute the grid's intrinsic size, the only way to handle
all these cases is to integrate the baseline alignment logic in the
algorithm.

Additionally, the CSSWG has identified several cases that can't be
solved properly; such cases have in common that they imply cyclic
dependencies between the item's and grid area's size. The CSSWG has
resolved that these items don't participate in baseline alignment:

w3c/csswg-drafts#1365

There are also other related issues with some examples and relevant
discussions about this topic:

w3c/csswg-drafts#1039
w3c/csswg-drafts#1409

Bug: 704713
Change-Id: I817b16eb43aa76f4827deb8f1f20efb7fde3dc22
Reviewed-on: https://chromium-review.googlesource.com/923261
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#562406}
@Hexcles

This comment has been minimized.

Copy link
Member

Hexcles commented May 29, 2018

@javifernandez one of the tests seems to be flaky on Travis. Could you take a look?

Test Subtest Results Messages
/css/css-grid/alignment/grid-column-axis-self-baseline-synthesized-003.html .grid 1 FAIL: 7/10, PASS: 3/10 assert_equals: \n<div class="grid width300 alignItemsBaseline">\n <div class="firstRowFirstColumn relativeHeight" data-offset-x="0" data-offset-y="0" data-expected-width="100" data-expected-height="100"></div>\n <div class="firstRowSecondColumn bigFont" data-offset-x="100" data-offset-y="60" data-expected-width="200" data-expected-height="100">É É ÉÉ</div>\n <div class="autoRowAutoColumnSpanning2 height25"></div>\n</div>\noffsetTop expected 0 but got -60
@Hexcles

This comment has been minimized.

Copy link
Member

Hexcles commented May 31, 2018

I'm admin-merging the PR as it will soon go out of the history window of Chromium's wpt-sync and will deal with the flakiness in Chromium (the test isn't flaky on Firefox).

@Hexcles Hexcles merged commit 82b2789 into master May 31, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@Hexcles Hexcles deleted the chromium-export-cl-923261 branch May 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.