Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selection{Start,End} test #9563

Merged

Conversation

Projects
None yet
4 participants
@emanchado
Copy link
Contributor

emanchado commented Feb 17, 2018

Likely due to a copy and paste error, one of the tests that was
meant to cover both selectionStart and selectionEnd only covered
the former. Fix so that it covers both, as it should have from the
start.

Fix selection{Start,End} test
Likely due to a copy and paste error, one of the tests that was
meant to cover both selectionStart and selectionEnd only covered
the former. Fix so that it covers both, as it should have from the
start.

@wpt-pr-bot wpt-pr-bot added the html label Feb 17, 2018

@wpt-pr-bot wpt-pr-bot requested review from ayg, jdm, jgraham and zqzhang Feb 17, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 17, 2018

Build PASSED

Started: 2018-02-17 09:01:34
Finished: 2018-02-17 09:09:02

View more information about this build on:

@jdm

jdm approved these changes Feb 17, 2018

Copy link
Contributor

jdm left a comment

Good catch!

@jdm jdm merged commit 08dd5d8 into web-platform-tests:master Feb 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@emanchado emanchado deleted the emanchado:fix-selection-start-end-test branch Feb 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.