Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] Fix crash involving negative length perspectives. #9567

Merged
merged 1 commit into from Feb 19, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 18, 2018

We were crashing because converting CSSPerspective(-1px) to a CSSValue
returns nullptr. The correct behaviour should be to convert it as
CSSPerspective(calc(-1px)).

Bug: 812620
Change-Id: I5ee70d4fb5eed064bcdad67391c3eb84531144d6
Reviewed-on: https://chromium-review.googlesource.com/924742
Commit-Queue: Darren Shen shend@chromium.org
Reviewed-by: nainar nainar@chromium.org
Cr-Commit-Position: refs/heads/master@{#537690}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 18, 2018

Build PASSED

Started: 2018-02-19 23:43:14
Finished: 2018-02-19 23:52:48

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-924742 branch from 4a4344d to 40d965a Feb 19, 2018

[css-typed-om] Fix crash involving negative length perspectives.
We were crashing because converting CSSPerspective(-1px) to a CSSValue
returns nullptr. The correct behaviour should be to convert it as
CSSPerspective(calc(-1px)).

Bug: 812620
Change-Id: I5ee70d4fb5eed064bcdad67391c3eb84531144d6
Reviewed-on: https://chromium-review.googlesource.com/924742
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537690}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-924742 branch from 40d965a to ed9d880 Feb 19, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 969ae69 into master Feb 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-924742 branch Feb 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.