Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] Handle out-of-range values correctly. #9568

Merged
merged 1 commit into from Feb 19, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 18, 2018

Currently, when we set width to something like -1, we would get an
invalid value for width. According to the spec [1], we should be
wrapping the invalid value in a calc.

This patch wraps invalid values in calc, and changes the test harness
to allow us to test this.

Bug: 545318
Change-Id: I71769e1bc69164c9b7dcf0d2c54ca06b623b5d9e
Reviewed-on: https://chromium-review.googlesource.com/923603
Commit-Queue: Darren Shen shend@chromium.org
Reviewed-by: nainar nainar@chromium.org
Cr-Commit-Position: refs/heads/master@{#537685}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 19, 2018

Build PASSED

Started: 2018-02-19 22:09:06
Finished: 2018-02-19 22:24:20

Failing Jobs

  • MicrosoftEdge:16.16299

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-923603 branch from 83371eb to 252d2b9 Feb 19, 2018

[css-typed-om] Handle out-of-range values correctly.
Currently, when we set width to something like -1, we would get an
invalid value for width. According to the spec [1], we should be
wrapping the invalid value in a calc.

This patch wraps invalid values in calc, and changes the test harness
to allow us to test this.

Bug: 545318
Change-Id: I71769e1bc69164c9b7dcf0d2c54ca06b623b5d9e
Reviewed-on: https://chromium-review.googlesource.com/923603
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537685}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-923603 branch from 252d2b9 to 3f6755c Feb 19, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit ca39b1e into master Feb 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-923603 branch Feb 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.